Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faust-types pulls in jack dependency #31

Open
obsoleszenz opened this issue Nov 20, 2024 · 1 comment
Open

faust-types pulls in jack dependency #31

obsoleszenz opened this issue Nov 20, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@obsoleszenz
Copy link
Collaborator

Currently faust_types has a default jack feature which for me feels weird. faust-types should not pull in the jack dependency.

I'm wondering if we actually need the jack dependency at all in faust-types. The libm dependency I could imagine we need, I think I remember that the rust std library didn't offer a couple of math methods that faust needs?

@amomentunfolding You made the import of libm and jack for faust-types optional in 63c0421 . Maybe you have a clearer idea on this?

Didn't play around with this yet, so this is mainly an issue to document that we can make things cleaner here.

@obsoleszenz obsoleszenz added the enhancement New feature or request label Nov 20, 2024
@crop2000
Copy link
Contributor

i think it makes sense to rename the feature flag to libm and remove jack which is not used at all.

crop2000 added a commit to crop2000/rust-faust that referenced this issue Jan 2, 2025
crop2000 added a commit to crop2000/rust-faust that referenced this issue Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants