Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound extension #686

Open
ferostabio opened this issue Jul 27, 2023 · 2 comments · May be fixed by #708
Open

Compound extension #686

ferostabio opened this issue Jul 27, 2023 · 2 comments · May be fixed by #708

Comments

@ferostabio
Copy link
Contributor

ferostabio commented Jul 27, 2023

@NikolaiYurchenko NikolaiYurchenko linked a pull request Aug 11, 2023 that will close this issue
@ferostabio
Copy link
Contributor Author

Original plan revolved around two points:

  • Using an iframe
  • Either incorporating the migrator into our full frontend app or creating a reusable migrator to be embedded.

First, the iframe route was the wrong take, since we can't just pass the signer. It would break everything, can't think of anything worst.

Then, making a reusable migrator is completely out of scope. It would mean rewriting a lot of our components, adding into a shared package, etc, and even then different extensions would force us to do things differently.

We will focus on having the Compound migrator flow working on their extension with our UI. We'll then worry about integrating the logic.

@NikolaiYurchenko
Copy link
Contributor

UPD:

  1. markup finished in app in Position migrator #708
  2. Trying to port markup here https://github.com/NikolaiYurchenko/comet-extenteion-test and push to fuji after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants