Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

Incorrect link to GitLink? #149

Open
Korporal opened this issue Mar 3, 2017 · 10 comments
Open

Incorrect link to GitLink? #149

Korporal opened this issue Mar 3, 2017 · 10 comments

Comments

@Korporal
Copy link

Korporal commented Mar 3, 2017

I was reading the readme which has a link to the NuGet package to install into Visual Studio. However it seems to be wrong (if you read issue #140).

Why do you have users install GitLInk nuget package rather than the GitLinkTask package which (it seems) is the one they should be installing?

Thanks

@GeertvanHorrik
Copy link
Contributor

Hi @Korporal ,

The frontpage shows the current develop branch which we are actively working on (but represents the prerelease of GL 3.0). If you check the master branch, you should see the correct docs.

Sorry for the temporary inconvenience.

@Korporal
Copy link
Author

Korporal commented Mar 3, 2017

Thanks @GeertvanHorrik but on that other readme I see now mention at all of adding a NuGet package to a project. I just tried to add GitLinkTask but it fails if proj is .Net 4.5.2 or 4.5 - no idea what min target framework must be.

Also what is the GitLink nuget package for if GitLinkTask is the one you really want us to install?

@GeertvanHorrik
Copy link
Contributor

It's the exe itself (installed as a tool). In v3, you will only have to install GitLink itself since it contains both the msbuild integration as the tool. @AArnott did all the hard work there, so he can best explain that process if you need more info.

@Korporal
Copy link
Author

Korporal commented Mar 3, 2017

@GeertvanHorrik
I've tried to install the GitLinkTask package three times now (in order to experiment) but it fails to install for .Net 4.52, .Net 4.5 and .Net 4.0 - what is the min framework that's compatible with GitLinkTask 2.4.1?

Thx

PS: installation also fails for .Net 3.5 and .Net 3.0:

"You are trying to install this package into a project that targets '.NETFramework,Version=v3.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author."

@GeertvanHorrik
Copy link
Contributor

Please install the latest pre-release, that's what we are going to recommend on the short term anyway. It should automatically integrate with msbuild, right @AArnott ?

@AArnott
Copy link
Contributor

AArnott commented Mar 4, 2017

@GeertvanHorrik is correct.
@Korporal there's no such thing as targeting .NET 3.0 I'm pretty sure. So your configuration sounds a bit wonky. That might explain why the older gitlinktask package won't install.

@hgleaves-ncuadmin
Copy link

@GeertvanHorrik @AArnott
Can you just confirm what .Net Framework versions are supported by the GitLinkTask package v 2.4.1? (the most recent version I can see on the Nuget site) or your pre-release, then I can proceed to use that.

Thanks

PS: I'm genuinely trying to evaluate this system, it sounds very good but the questions I'm asking are real, they stem from me trying to understand what's written here and what's published here.

@GeertvanHorrik
Copy link
Contributor

@hgleaves-ncuadmin Different question: what system are your targeting, that's easier for us to answer. I believe both use .NET FX 4.0 as base, so should work on everything above that. If it's an msbuild task, the target platform should be irrelevant (since it's msbuild invoking the assembly). @AArnott can you confirm I'm not making a mistake here?

@AArnott
Copy link
Contributor

AArnott commented Mar 6, 2017

Wow. I just downloaded the GitLinkTask 2.4.1 package (I've never looked at it before). It only has a build\dotnet folder. I'd be surprised if this worked for any target framework. It seems it would only work for old DNX projects.

@GeertvanHorrik
Copy link
Contributor

@hgleaves-ncuadmin let's ignore the current (soon to be old) version of GitLink. Could you please try the unstable GitLink msbuild integration to see if that works out for you?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants