Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The anonymous donations should be counted in number of contributors #1805

Open
maryjaf opened this issue Sep 9, 2024 · 6 comments
Open

The anonymous donations should be counted in number of contributors #1805

maryjaf opened this issue Sep 9, 2024 · 6 comments

Comments

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 9, 2024

Based on Griff's comment, the anonymous donations should be counted in number of contributors

As you can see in below pic there is 1 unique donor if the anonymous donations aren't counted
but based on new requirment the anonymous should be counted

image

cc: @mohammadranjbarz @Meriem-B

@MoeNick
Copy link
Member

MoeNick commented Sep 9, 2024

We don't know how many anons are those, so I don;t think it's a good idea.

@Meriem-BM Meriem-BM self-assigned this Sep 9, 2024
@maryjaf
Copy link
Collaborator Author

maryjaf commented Sep 9, 2024

We don't know how many anons are those, so I don;t think it's a good idea.

I infer form Griff's comment that every anonymous donation should be counted as a one unique contributor

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Oct 3, 2024
@divine-comedian divine-comedian moved this from New Issues to Dev Research in All-Devs Oct 3, 2024
@Meriem-BM
Copy link
Member

Hey @MoeNick I'm checking some issues now, what do we think about this one, should we still be considering it?

cc: @maryjaf

@MoeNick
Copy link
Member

MoeNick commented Jan 9, 2025

I can't find a robust solution to find a unique number of anon donors, unless we assume a sender address as an anon donor, so each sender address that is not related to a userID would sound like one anon-Donor (tbh that assumption is not always valid)
Im not sure we have the sender address in donations records, but if we have, it might be a good idea to count the unique userID plus the unique sender address to solve this problem.

First I'd suggest to check logic of current counting donors fro all chains.

@Meriem-BM

@MoeNick
Copy link
Member

MoeNick commented Jan 9, 2025

As far as Im not contributing on Giveth these days, @divine-comedian should be in the loop for this and making the final decision.

@Meriem-BM Meriem-BM moved this from Research & Planning to In Progress in All-Devs Jan 9, 2025
@divine-comedian
Copy link
Collaborator

@Meriem-BM lets remove this one from our plate for now.

@divine-comedian divine-comedian moved this from In Progress to Research & Planning in All-Devs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Research & Planning
Development

No branches or pull requests

4 participants