Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'course_group' in form shadows 'course_group' in path, which hides it in documentation #44

Closed
alexdlaird opened this issue Jan 2, 2018 · 1 comment
Assignees
Labels
documentation This issue requires a documentation change enhancement New feature or request help wanted Extra attention is needed

Comments

@alexdlaird
Copy link
Member

When updating a Course, you may pass a "course_group" parameter in the body to move the course from one CourseGroup to another. Since this field shadows the course_group in the path (which maps to the current CourseGroup, whereas the one in the body maps to the CourseGroup to be moved to), the generated documentation removes the "course_group" field from the body.

This is also true when updating a Material.

As this functionality is not currently supported by the frontend anyway, this is a low priority, especially given the functionality itself also works. But documentation should be updated to reflect.

@alexdlaird alexdlaird added documentation This issue requires a documentation change enhancement New feature or request labels Jan 2, 2018
@alexdlaird alexdlaird self-assigned this Jan 2, 2018
@alexdlaird alexdlaird added the help wanted Extra attention is needed label Jan 21, 2018
@alexdlaird
Copy link
Member Author

Closing, as the Helium project is not currently active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue requires a documentation change enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant