Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is not a clean architecture #5

Open
nuculerman opened this issue Apr 21, 2022 · 0 comments
Open

This is not a clean architecture #5

nuculerman opened this issue Apr 21, 2022 · 0 comments

Comments

@nuculerman
Copy link

There are a lot of problems with this solution. The biggest and most glaring being the dependency on Infrastructure from Application through IDocumentContext (and there's even raw SQL statements in Application -- YIKES). This could have been and should be easily fixed by moving IDocumentContext to the Application project -- i.e. Dependency Inversion 101 and basically the underlying principle of "Clean Architecture."

It seems like there was a lot of work put into this code base and it's a pity this oversight renders it a very poor example of Clean Architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant