Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 php_strtolower warnings #689

Open
lukaszmarcola opened this issue Sep 25, 2024 · 1 comment
Open

PHP 8.4 php_strtolower warnings #689

lukaszmarcola opened this issue Sep 25, 2024 · 1 comment

Comments

@lukaszmarcola
Copy link

Hello,
since php84 rc1 some functions like php_strtolower was removed and they suggest to use zend_str_tolower:
php/php-src@85e6688#diff-8792658491c2da2691aa3492fee6304154346d593fa1d787ebb897d0467d58efR379

During compilation, I get:

/home/build/rpmbuild/BUILD/imagick-3.7.0/imagick.c: In function 'php_imagick_read_property':
/home/build/rpmbuild/BUILD/imagick-3.7.0/imagick.c:606:7: warning: implicit declaration of function 'php_strtolower'; did you mean 'php_strtok_r'? [-Wimplicit-function-declaration]
       php_strtolower(Z_STRVAL_P(retval), Z_STRLEN_P(retval));
       ^~~~~~~~~~~~~~
       php_strtok_r

An update of these functions is probably required.

@mvorisek
Copy link

see #690

for PHP 8.4 Docker images you can use https://github.com/mvorisek/image-php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants