Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

7.1 support? #94

Closed
csdougliss opened this issue Dec 6, 2016 · 8 comments
Closed

7.1 support? #94

csdougliss opened this issue Dec 6, 2016 · 8 comments
Assignees

Comments

@csdougliss
Copy link

No description provided.

@icurdinj
Copy link
Contributor

icurdinj commented Dec 6, 2016

Not tested yet, but due to very little gain from 7.1 compared to 7.0, it isn't a priority.

@csdougliss
Copy link
Author

@icurdinj The only benchmarks I've found so far:

http://phoronix.com/scan.php?page=news_item&px=PTS-PHP-7.1-Benchmarks

@ivanweiler
Copy link
Contributor

ivanweiler commented Dec 30, 2016

Just tested Magento CE 1.9.3.1 on PHP 7.1.0, everything seems fine here.

Only one log warrning mentioned in separate issue #97 , but everything is working.

@jgeerdink Orders are working fine here, both My Account and admin. Did you find out what's wrong, maybe is related to payment method used, which payment is used on that orders?

@icurdinj
Copy link
Contributor

Supported, but pointless: https://github.com/Inchoo/Inchoo_PHP7/wiki/RunningOnPHP7.1

@gamort
Copy link

gamort commented Feb 17, 2017

I'm not so sure about pointless. If the issue is mainly deprecation warnings, I think a better solution would be to disable those warnings[since no one reads them anyway]

The benefit's are mainly regarding perceived PCI Compliance.
http://php.net/supported-versions.php

Some auditors make their decision based on the level of support the installed PHP Version has. 7.0 will go from supported to Security Fixes Only in January 2018, and no support January 2019

This leaves 1.x sites which are not end of life from January 2018 till November 2017 with potential business[though not technical] issues.

Jumping directly to 7.1 avoids business issues at the cost of a few technical issues.

@icurdinj
Copy link
Contributor

@gamort : "I think a better solution would be to disable those warnings[since no one reads them anyway]"
@benjamw : "I have my error reporting turned all the way up (E_ALL), so I'm not hiding anything when I code. "

Round 1, fight! :-)

@benjamw
Copy link
Contributor

benjamw commented Mar 1, 2017

*POW* *BIFF* *BANG*

TABS ARE BETTER THAN SPACES!

@icurdinj
Copy link
Contributor

icurdinj commented Mar 1, 2017

I agree that tabs are better than spaces!
But, PSR-2...
And standards are better than chaos...
Damn...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants