Add discounts #182
Draft
Add discounts #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
insalan/payment/models.py:442
- [nitpick] The error message 'Discount already used' could be more user-friendly. Consider changing it to 'This discount has already been used.'
raise DiscountAlreadyUsedError("Discount already used")
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
insalan/payment/models.py:442
- Add a test to cover the scenario where a discount is already used and the
DiscountAlreadyUsedErroris raised.
raise DiscountAlreadyUsedError("Discount already used")
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
insalan/payment/models.py:425
- [nitpick] Consider adding validation for the length and content of the reason field.
reason = models.CharField(max_length=200, verbose_name=_("Motif"))
insalan/payment/views.py:434
- The comment on line 434 should be aligned with the code block it describes for better readability.
# Check if the discount is applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a way to create a discount for a given user + product.
Discount will then be subtracted from the payment total and marked as used when the payment is successful.
TODO : add documentation
Checklist
Related Issues
Fix #181
Screenshots