Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 SPO vote total on mainnet is incorrect #2609

Closed
Ryun1 opened this issue Jan 7, 2025 · 4 comments · Fixed by #2616
Closed

🐛 SPO vote total on mainnet is incorrect #2609

Ryun1 opened this issue Jan 7, 2025 · 4 comments · Fixed by #2616
Assignees
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar

Comments

@Ryun1
Copy link
Member

Ryun1 commented Jan 7, 2025

Area

Voting Pillar

Domain

gov.tools

Which wallet were you using?

No response

Context

Steps to reproduce

Go to https://gov.tools/governance_actions/0b19476e40bbbb5e1e8ce153523762e2b6859e7ecacbaf06eae0ee6a447e79b9#0

compare to https://adastat.net/governances/0b19476e40bbbb5e1e8ce153523762e2b6859e7ecacbaf06eae0ee6a447e79b900

Actual behavior

very misaligned values

Expected behavior

very similar values

@Ryun1 Ryun1 added the 🐛 Bug Something isn't working label Jan 7, 2025
@Ryun1
Copy link
Member Author

Ryun1 commented Jan 7, 2025

Is SPO vote totals, calculated on the fly or once per epoch?

@MSzalowski
Copy link
Contributor

Once per epoch

@Ryun1
Copy link
Member Author

Ryun1 commented Jan 8, 2025

The next boundary is tomorrow night
so lets wait see on Friday if the totals between GovTool and other sites are closer aligned

@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Jan 8, 2025
@MSzalowski
Copy link
Contributor

We have a bug. We are using drep_distr amounts for calculating the total stake for spos but as table name states drep_distr is for DReps not SPOs, meaning the values taken from that table wouldn't be correct even after next boundary.

It looks like it is quite critical bug, that we should address as P0, and push it to main ASAP.

What do you think @bosko-m ?

@MSzalowski MSzalowski linked a pull request Jan 9, 2025 that will close this issue
5 tasks
MSzalowski added a commit that referenced this issue Jan 9, 2025
…-mainnet-is-incorrect

fix(#2609): fix wrong SPO vote totals
@github-project-automation github-project-automation bot moved this from In progress to Done in Govtool all Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants