Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspected flaky failure of "shrink for GovernorMockEnvironment" QuickCheck property #5024

Open
nfrisby opened this issue Dec 11, 2024 · 1 comment
Labels
test-failure a test failure

Comments

@nfrisby
Copy link
Contributor

nfrisby commented Dec 11, 2024

I strongly suspect that this CI failure is not the PR's fault.

https://ci.iog.io/build/5987622/nixlog/1 from #5009 when it was at commit b7cba34

      shrink for GovernorMockEnvironment:                                       FAIL (58.23s)
        *** Failed! Falsified (after 47 tests and 311 shrinks):
        ShrinkCarefully (GovernorMockEnvironment {peerGraph = PeerGraph [], localRootPeers = fromGroups [], publicRootPeers = PublicRootPeers {getPublicConfigPeers = fromList [], getBootstrapPeers = fromList [], getLedgerPeers = fromList [], getBigLedgerPeers = fromList []}, targets = Script ((ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 10, targetNumberOfEstablishedBigLedgerPeers = 1, targetNumberOfActiveBigLedgerPeers = 1}},NoDelay) :| [(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 18, targetNumberOfEstablishedBigLedgerPeers = 9, targetNumberOfActiveBigLedgerPeers = 9}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 28, targetNumberOfEstablishedBigLedgerPeers = 28, targetNumberOfActiveBigLedgerPeers = 14}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 10, targetNumberOfEstablishedBigLedgerPeers = 1, targetNumberOfActiveBigLedgerPeers = 1}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 308, targetNumberOfEstablishedBigLedgerPeers = 308, targetNumberOfActiveBigLedgerPeers = 72}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 38, targetNumberOfEstablishedBigLedgerPeers = 36, targetNumberOfActiveBigLedgerPeers = 36}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 110, targetNumberOfEstablishedBigLedgerPeers = 55, targetNumberOfActiveBigLedgerPeers = 49}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 96, targetNumberOfEstablishedBigLedgerPeers = 96, targetNumberOfActiveBigLedgerPeers = 48}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 10, targetNumberOfEstablishedBigLedgerPeers = 5, targetNumberOfActiveBigLedgerPeers = 3}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 11, targetNumberOfKnownPeers = 21, targetNumberOfEstablishedPeers = 10, targetNumberOfActivePeers = 8, targetNumberOfKnownBigLedgerPeers = 353, targetNumberOfEstablishedBigLedgerPeers = 81, targetNumberOfActiveBigLedgerPeers = 47}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 88, targetNumberOfKnownPeers = 630, targetNumberOfEstablishedPeers = 162, targetNumberOfActivePeers = 84, targetNumberOfKnownBigLedgerPeers = 1001, targetNumberOfEstablishedBigLedgerPeers = 1001, targetNumberOfActiveBigLedgerPeers = 56}},NoDelay)]), pickKnownPeersForPeerShare = Script (PickFirst :| []), pickColdPeersToPromote = Script (PickFirst :| []), pickWarmPeersToPromote = Script (PickFirst :| []), pickHotPeersToDemote = Script (PickFirst :| []), pickWarmPeersToDemote = Script (PickFirst :| []), pickColdPeersToForget = Script (PickFirst :| []), pickInboundPeers = Script (PickFirst :| []), peerSharingFlag = PeerSharingDisabled, useBootstrapPeers = Script ((DontUseBootstrapPeers,NoDelay) :| []), consensusMode = PraosMode, useLedgerPeers = Script ((UseLedgerPeers (After (SlotNo 108)),NoDelay) :| []), ledgerStateJudgement = Script ((TooOld,ShortDelay) :| [])})
        shrink result invalid:
        GovernorMockEnvironment {peerGraph = PeerGraph [], localRootPeers = fromGroups [], publicRootPeers = PublicRootPeers {getPublicConfigPeers = fromList [], getBootstrapPeers = fromList [], getLedgerPeers = fromList [], getBigLedgerPeers = fromList []}, targets = Script ((ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 10, targetNumberOfEstablishedBigLedgerPeers = 1, targetNumberOfActiveBigLedgerPeers = 1}},NoDelay) :| [(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 18, targetNumberOfEstablishedBigLedgerPeers = 9, targetNumberOfActiveBigLedgerPeers = 9}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 28, targetNumberOfEstablishedBigLedgerPeers = 28, targetNumberOfActiveBigLedgerPeers = 14}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 10, targetNumberOfEstablishedBigLedgerPeers = 1, targetNumberOfActiveBigLedgerPeers = 1}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 308, targetNumberOfEstablishedBigLedgerPeers = 308, targetNumberOfActiveBigLedgerPeers = 72}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 38, targetNumberOfEstablishedBigLedgerPeers = 36, targetNumberOfActiveBigLedgerPeers = 36}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 110, targetNumberOfEstablishedBigLedgerPeers = 55, targetNumberOfActiveBigLedgerPeers = 49}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 96, targetNumberOfEstablishedBigLedgerPeers = 96, targetNumberOfActiveBigLedgerPeers = 48}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 0, targetNumberOfEstablishedPeers = 0, targetNumberOfActivePeers = 0, targetNumberOfKnownBigLedgerPeers = 10, targetNumberOfEstablishedBigLedgerPeers = 5, targetNumberOfActiveBigLedgerPeers = 3}},NoDelay),(ConsensusModePeerTargets {deadlineTargets = PeerSelectionTargets {targetNumberOfRootPeers = 11, targetNumberOfKnownPeers = 21, targetNumberOfEstablishedPeers = 10, targetNumberOfActivePeers = 8, targetNumberOfKnownBigLedgerPeers = 353, targetNumberOfEstablishedBigLedgerPeers = 81, targetNumberOfActiveBigLedgerPeers = 47}, syncTargets = PeerSelectionTargets {targetNumberOfRootPeers = 88, targetNumberOfKnownPeers = 630, targetNumberOfEstablishedPeers = 162, targetNumberOfActivePeers = 84, targetNumberOfKnownBigLedgerPeers = 1001, targetNumberOfEstablishedBigLedgerPeers = 1001, targetNumberOfActiveBigLedgerPeers = 56}},NoDelay)]), pickKnownPeersForPeerShare = Script (PickFirst :| []), pickColdPeersToPromote = Script (PickFirst :| []), pickWarmPeersToPromote = Script (PickFirst :| []), pickHotPeersToDemote = Script (PickFirst :| []), pickWarmPeersToDemote = Script (PickFirst :| []), pickColdPeersToForget = Script (PickFirst :| []), pickInboundPeers = Script (PickFirst :| []), peerSharingFlag = PeerSharingDisabled, useBootstrapPeers = Script ((DontUseBootstrapPeers,NoDelay) :| []), consensusMode = PraosMode, useLedgerPeers = Script ((UseLedgerPeers (After (SlotNo 108)),NoDelay) :| []), ledgerStateJudgement = Script ((TooOld,NoDelay) :| [])}
        failed peer selection targets sanity check
        Use --quickcheck-replay="(SMGen 11833974983043389638 8556701760956386167,16)" to reproduce.
        Use -p '/shrink for GovernorMockEnvironment/' to rerun this test only.```
        
@nfrisby
Copy link
Contributor Author

nfrisby commented Dec 11, 2024

FYI @coot as you requested during our call just now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-failure a test failure
Projects
Status: No status
Development

No branches or pull requests

1 participant