Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeepAlive Responder Should Not Be Started On Demand #5037

Open
karknu opened this issue Jan 14, 2025 · 0 comments
Open

KeepAlive Responder Should Not Be Started On Demand #5037

karknu opened this issue Jan 14, 2025 · 0 comments
Assignees
@karknu
Labels
bug Something isn't working connection-manager Issues / PRs related to connection-manager high-priority high priority issues / PRs inbound-governor Issues / PRs related to inbound-governor

Comments

@karknu
Copy link
Contributor

karknu commented Jan 14, 2025

The KeepAlive responder is started on demand in the p2p stack. This means that a client that only run for example chainsync or txsubmission could cause dangling connections.

The KeepAlive responder should be started eagerly. Duplex connections can live through many cold to warm to cold cycles, and in that case the KeepAlive responder should be started eagerly as soon as any responder protocol starts.
@karknu karknu added bug Something isn't working connection-manager Issues / PRs related to connection-manager inbound-governor Issues / PRs related to inbound-governor labels Jan 14, 2025
@coot coot added the high-priority high priority issues / PRs label Jan 14, 2025
@karknu karknu self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karknu karknu

Labels
bug Something isn't working connection-manager Issues / PRs related to connection-manager high-priority high priority issues / PRs inbound-governor Issues / PRs related to inbound-governor
Projects
Ouroboros Network
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coot @karknu