Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GetReport to take a pointer to a user/client provided struct #2

Open
ddouglas opened this issue Apr 21, 2021 · 1 comment
Open

Comments

@ddouglas
Copy link

This is one of two repo's that I've found on here that take care of the complicated part of ingesting data from the SimConnect.dll, so to start off with, thank you for writing this lib. I've been using it the past couple of nights as tool for trying to understand how a Go Application can talk to a C API via DDLs.

My idea or feature request, and I can submit a PR for the initial parts to see what you think, it to allow the package consumer to provide a struct. Since reflection is already being used to get the name and unit fields, we can tap into that to do some validation if you feel it is warranted. Im going to go ahead and fork the repo and see what i can do myself.

@JRascagneres
Copy link
Owner

Yeah that'd be great!
A few other options are out there and only have the low level functions but I aimed to provide higher level functions to get data out and abstract some of the lower functions.
Having said that I agree it'd be nice to further expose lower level functions to allow for more customization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants