From 047347a2f473ee095f5f5b0bcf3dcb4247515e05 Mon Sep 17 00:00:00 2001
From: Julian P Samaroo <jpsamaroo@jpsamaroo.me>
Date: Mon, 16 Dec 2024 15:32:23 -0600
Subject: [PATCH] fixup! tests: Add --no-test option

---
 test/runtests.jl | 48 +++++++++++++++++++++++++++---------------------
 1 file changed, 27 insertions(+), 21 deletions(-)

diff --git a/test/runtests.jl b/test/runtests.jl
index 5685d032..93f903bf 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -47,12 +47,14 @@ if PROGRAM_FILE != "" && realpath(PROGRAM_FILE) == @__FILE__
     @eval begin
         @add_arg_table! s begin
             "--test"
-                nargs = '*'
-                default = all_test_names
+                nargs = 1
+                action = :append_arg
+                arg_type = String
                 help = "Enables the specified test to run in the testsuite"
             "--no-test"
-                nargs = '*'
-                default = String[]
+                nargs = 1
+                action = :append_arg
+                arg_type = String
                 help = "Disables the specified test from running in the testsuite"
             "-s", "--simulate"
                 action = :store_true
@@ -72,31 +74,35 @@ if PROGRAM_FILE != "" && realpath(PROGRAM_FILE) == @__FILE__
 
     parsed_args = parse_args(s)
     to_test = String[]
-    for test in parsed_args["test"]
-        if isdir(joinpath(@__DIR__, test))
-            for (_, other_test) in tests
-                if startswith(other_test, test)
-                    push!(to_test, other_test)
-                    continue
+    if isempty(parsed_args["test"])
+        to_test = copy(all_test_names)
+    else
+        for _test in parsed_args["test"]
+            test = only(_test)
+            if isdir(joinpath(@__DIR__, test))
+                for (_, other_test) in tests
+                    if startswith(other_test, test)
+                        push!(to_test, other_test)
+                    end
                 end
+            elseif test in all_test_names
+                push!(to_test, test)
+            else
+                println(stderr, "Unknown test: $test")
+                println(stderr, "Available tests:")
+                for ((test_title, _), test_name) in zip(tests, all_test_names)
+                    println(stderr, "  $test_name: $test_title")
+                end
+                exit(1)
             end
-        elseif test in all_test_names
-            push!(to_test, test)
-        else
-            println(stderr, "Unknown test: $test")
-            println(stderr, "Available tests:")
-            for ((test_title, _), test_name) in zip(tests, all_test_names)
-                println(stderr, "  $test_name: $test_title")
-            end
-            exit(1)
         end
     end
-    for test in parsed_args["no-test"]
+    for _test in parsed_args["no-test"]
+        test = only(_test)
         if isdir(joinpath(@__DIR__, test))
             for (_, other_test) in tests
                 if startswith(other_test, test)
                     filter!(x -> x != other_test, to_test)
-                    continue
                 end
             end
         elseif test in all_test_names