Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to the project #23

Open
KGergo88 opened this issue Jun 23, 2019 · 1 comment · May be fixed by #32
Open

Add unit tests to the project #23

KGergo88 opened this issue Jun 23, 2019 · 1 comment · May be fixed by #32
Assignees
Labels
enhancement New, or improved functionality ongoing This issue needs continuous updates as the project goes on and might never be closed

Comments

@KGergo88
Copy link
Owner

KGergo88 commented Jun 23, 2019

TODO:

@KGergo88 KGergo88 added enhancement New, or improved functionality in progress The issue is currently being worked on labels Jun 23, 2019
@KGergo88 KGergo88 self-assigned this Jun 23, 2019
@KGergo88
Copy link
Owner Author

KGergo88 commented Jun 27, 2019

Bugs found and corrected during test development:

DataPoint

- The getters were returning references instead of copying values
- Corrected const modifiers in the setters

DataLine

- Missing return in DataLine::operator<<
- The getters were returning references instead of copying values

Diagram

- The GetDataPoint member was returning references instead of copying values 

Configuration

- The handling of outdated config files was not correctly implemented

MeasurementDataProtocol

- The file format string constant had an extra dot at the beginning

@KGergo88 KGergo88 added the ongoing This issue needs continuous updates as the project goes on and might never be closed label Aug 17, 2019
@KGergo88 KGergo88 removed the in progress The issue is currently being worked on label Apr 13, 2020
@sberegszaszi sberegszaszi linked a pull request Jul 22, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New, or improved functionality ongoing This issue needs continuous updates as the project goes on and might never be closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant