Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

badges: bug introduced by cleaning?! #49

Open
mrustl opened this issue Mar 16, 2019 · 1 comment
Open

badges: bug introduced by cleaning?! #49

mrustl opened this issue Mar 16, 2019 · 1 comment
Assignees
@hsonne
Labels
bug Something isn't working

Comments

@mrustl
Copy link
Member

mrustl commented Mar 16, 2019

Using a86bfaa has bugs if function use_index_rmd() or use_readme_md() are called (see for example https://raw.githubusercontent.com/KWB-R/kwb.vs2dh/343406e4629f32343b3e38bb468b248cbb1be2c7/README.md)

kwb.pkgbuild::use_badge_cran("kwb.vs2dh")`
[1] "[![CRAN_Status_Badge](https://www.r-pkg.org/badges/version/<pkgname>)]()"

Please fix the bug introduced by cleaning and add a test
@mrustl mrustl added the bug Something isn't working label Mar 16, 2019
hsonne added a commit that referenced this issue Mar 16, 2019
@hsonne
Fix bug in use_badge_cran()
af6790d 
This fix should close issue #49.

The function is_on_cran() can now handle more than
one link. It does the sapply internally.
@mrustl
Copy link
Member Author

mrustl commented Mar 17, 2019

Still not completly solved see KWB-R/kwb.pathdict#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsonne hsonne

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsonne @mrustl