Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: "citations" button not working in algolia div #67

Open
1 of 2 tasks
mrustl opened this issue Sep 14, 2020 · 5 comments · Fixed by #66
Open
1 of 2 tasks

bug: "citations" button not working in algolia div #67

mrustl opened this issue Sep 14, 2020 · 5 comments · Fixed by #66
Assignees
@stinlemp
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone
v0.2

Comments

@mrustl
Copy link
Member

mrustl commented Sep 14, 2020 •
edited by stinlemp
Loading

The button for opening class "js-cite-modal" is not working from the Algolia "hits" results div but is working for a single publication e.g. https://deploy-preview-64--kwb.netlify.app/de/publication/1252/ but not https://deploy-preview-64--kwb.netlify.app/de/publication here.

To do:

  • quick fix: replace with simple download button (fixed in f1316c4)
  • long-term fix: research why this is not working and fix using "js-cite-modal" class
@mrustl mrustl added the bug Something isn't working label Sep 14, 2020
@mrustl mrustl added this to the v0.2 milestone Sep 14, 2020
@mrustl mrustl self-assigned this Sep 14, 2020
mrustl added a commit that referenced this issue Sep 14, 2020
@mrustl
quick fix for ".js-cite-modal" bug (#67)
754fafd 
not working in Algolia hits div
mrustl added a commit that referenced this issue Sep 14, 2020
@mrustl
cite: try long-term fix (#67)
0756a5b 
by explicitly defining "js-cite-modal" to
"hits" widget (hoping that inheritance will solve the problem!)
@mrustl mrustl closed this as completed Sep 14, 2020
mrustl added a commit that referenced this issue Sep 14, 2020
@mrustl
rollback to bug (#67) as defining css class
871276e 
did overwrite all other css classes
mrustl added a commit that referenced this issue Sep 14, 2020
@mrustl
cite: rollback to simple solution (#67)
f1316c4
@mrustl mrustl reopened this Sep 14, 2020
@mrustl
Copy link
Member Author

mrustl commented Sep 14, 2020

c281ffc solved the "cite" problem but introduced quite a few new as inheritance made all former links unusable....

@mrustl mrustl linked a pull request Sep 14, 2020 that will close this issue
matomo: make configurable (#65) #66
Merged
@mrustl mrustl added the help wanted Extra attention is needed label Aug 25, 2021
@mrustl mrustl assigned stinlemp and unassigned mrustl Aug 25, 2021
@mrustl
Copy link
Member Author

mrustl commented Aug 25, 2021

@stinlemp maybe you help fixing this ?

@stinlemp
Copy link
Collaborator

@mrustl Fixed this in the redesign branch. https://redesign--kwb.netlify.app/de/publication/

@mrustl
Copy link
Member Author

mrustl commented Aug 25, 2021

@stinlemp I think it is still open.

This was my current simple fix for the Algolia "citation" button:
Bildschirmfoto vom 2021-08-25 10-31-40

But the original download button (which is now only working for each publication site, e.g. https://redesign--kwb.netlify.app/de/publication/1311/) was this:

Bildschirmfoto vom 2021-08-25 10-32-21

@stinlemp
Copy link
Collaborator

@mrustl Hm works for me, maybe a browser/system issue. Will have a look on this when finalising the page.
Bildschirmfoto 2021-08-25 um 10 45 36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stinlemp stinlemp

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
v0.2
Development

Successfully merging a pull request may close this issue.

matomo: make configurable (#65) KWB-R/pubs
2 participants
@stinlemp @mrustl