From ecdd2cce89d0e8edf528ddb8bf262f4d820b390f Mon Sep 17 00:00:00 2001 From: Tac Tacelosky Date: Mon, 9 Dec 2024 12:42:53 -0500 Subject: [PATCH 1/3] fix nullable declaration for php 8.4 --- src/Packagist/Api/Client.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Packagist/Api/Client.php b/src/Packagist/Api/Client.php index 79b046b..7ada102 100644 --- a/src/Packagist/Api/Client.php +++ b/src/Packagist/Api/Client.php @@ -31,8 +31,8 @@ class Client * @param string $packagistUrl Packagist URL */ public function __construct( - ClientInterface $httpClient = null, - Factory $resultFactory = null, + ?ClientInterface $httpClient = null, + ?Factory $resultFactory = null, string $packagistUrl = 'https://packagist.org' ) { if (null === $httpClient) { From 331bccce8d64e3ca59e3729e78a5192e59885319 Mon Sep 17 00:00:00 2001 From: Tac Tacelosky Date: Mon, 9 Dec 2024 12:47:18 -0500 Subject: [PATCH 2/3] add 8.4 to the matrix --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a8287ed..2f36e7a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,7 +8,7 @@ jobs: strategy: matrix: - php-versions: ['7.4', '8.0', '8.1', '8.2', '8.3'] + php-versions: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4'] name: PHP ${{ matrix.php-versions }} From 5ee2a2fc7cc09033fcaee079aa11e0f66cc166aa Mon Sep 17 00:00:00 2001 From: Tac Tacelosky Date: Mon, 9 Dec 2024 16:34:38 -0500 Subject: [PATCH 3/3] revert 8.4 addition --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2f36e7a..a8287ed 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,7 +8,7 @@ jobs: strategy: matrix: - php-versions: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4'] + php-versions: ['7.4', '8.0', '8.1', '8.2', '8.3'] name: PHP ${{ matrix.php-versions }}