Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts when using with Trajectories mod #30

Closed
AlexALX opened this issue Nov 25, 2017 · 5 comments
Closed

Artifacts when using with Trajectories mod #30

AlexALX opened this issue Nov 25, 2017 · 5 comments

Comments

@AlexALX
Copy link

AlexALX commented Nov 25, 2017

Hello, i'm not sure how to properly report about issue, so i'm writing here.

When i install this mod with Trajectories together i have artifacts in map view when there is trajectory prediction - game start flicker with ocean or atmosphere. If there is no prediction for atmosphere entering there is no artifacts.

Here is screenshots:
https://imgur.com/a/pSq0W

I'm not sure what exactly wrong and in what addon is incompatibility, so writing to both addons.
neuoy/KSPTrajectories#119

@LGhassen
Copy link
Owner

Hello, can you try the latest dev version and tell me if you still have this behaviour?

You can grab the .dll from here: https://github.com/LGhassen/Scatterer/blob/d119b3cd5b53ac012f0ae0bc5c68a0623cf6644a/scatterer/bin/Release/scatterer.dll?raw=true

Just overwrite the one in your GameData.

@AlexALX
Copy link
Author

AlexALX commented Nov 27, 2017

Ok, i checked and issue still here.

@AlexALX
Copy link
Author

AlexALX commented Nov 28, 2017

After some manipulations with my GameData folder i detected when exactly this bug start appear - if use ksp with scatterer + trajectories + WindowShine. If i remove WindowShine then everything is ok for both mods. So incompatibility is with WindowShine and not scatterer/trajectories. So please check it with WindowShine. I'm going to report about issue to this mod too.

@AlexALX
Copy link
Author

AlexALX commented Nov 28, 2017

And i'm just qouting:

but I did notice a number of errors from scatterer. maybe you can pass on the information to them and see what they say.

[Scatterer] Error calling clouds2d.reassign() on planet: KerbinSystem.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary. at System.Collections.Generic.Dictionary2[System.String,System.Collections.Generic.List1[System.Object]].get_Item (System.String key) [0x00000] in :0 at scatterer.SkyNode.UpdateNode () [0x00000] in :0

Also a number of NRE's

NullReferenceException: Object reference not set to an instance of an object at scatterer.RefractionCamera.OnPreCull () [0x00000] in :0 (Filename: Line: -1) skynode added refraction cam

@LGhassen
Copy link
Owner

LGhassen commented Dec 2, 2017

I reproduced the issue and will be checking it out.

Edited: I tried this without scatterer and there seems to be flashing artifacts in map view when using both trajectories and textureReplacerReplaced (used by windowshine).

These artifacts to me resemble IVA view or some kind of glitched out local camera from inside the ship.

My guess would be that trajectories re-enables the local cameras in map view for some reason when used with textureReplacerReplaced, no issues in the logs or anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants