Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better propagation of an 'id' when used with our input components #535

Open
danparnella opened this issue Mar 1, 2022 · 0 comments
Open
Assignees

Comments

@danparnella
Copy link
Contributor

Issue

  • Relevant Comment Thread in artlook-client
  • Currently, when an id is passed into a non-group type input component (like Checkbox), that ends up being applied to the LabelComponent along with the input itself.
  • When an id is passed into a group type input component (like RadioGroup), that ends up being applied to LabelComponent that wraps the whole group, as well as each LabelComponent for each radio input component.

Proposal

  • Don't apply the id to the LabelComponent, keep it only on the input itself for non-group type input components
  • Ignore the id entirely for group type input components (as the id value for these inputs needs to be set programmatically)
  • I didn't audit every input component so there may be differences not surfaced here
@danparnella danparnella self-assigned this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant