From 5fa7ec78803e8bc89b16dc107ef5862ba2eab2c5 Mon Sep 17 00:00:00 2001 From: Angus Bayley Date: Thu, 16 Jan 2025 10:22:14 +0000 Subject: [PATCH 1/2] ci: authenticate with docker before running ghcommit action --- .../actions/composites/update-snapshots-desktop/action.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/actions/composites/update-snapshots-desktop/action.yml b/tools/actions/composites/update-snapshots-desktop/action.yml index 0c864e4aa0d7..2cac6f7d1b66 100644 --- a/tools/actions/composites/update-snapshots-desktop/action.yml +++ b/tools/actions/composites/update-snapshots-desktop/action.yml @@ -11,6 +11,12 @@ inputs: runs: using: "composite" steps: + - name: Docker Hub Login + uses: docker/login-action@v2 + with: + username: ${{ secrets.DOCKER_HUB_USERNAME }} + password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} + - name: Update playwright snapshots [Linux => xvfb-run] if: ${{ startsWith(inputs.os, 'ubuntu') }} run: | From 610ae6b2ea4eb3167e51d103632f5dc512f3a3fe Mon Sep 17 00:00:00 2001 From: Angus Bayley Date: Thu, 16 Jan 2025 10:45:51 +0000 Subject: [PATCH 2/2] auth in workflow instead of action --- .github/workflows/generate-screenshots.yml | 5 +++++ .../actions/composites/update-snapshots-desktop/action.yml | 6 ------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/generate-screenshots.yml b/.github/workflows/generate-screenshots.yml index a3b0a343cc3b..2e56e3c5515b 100644 --- a/.github/workflows/generate-screenshots.yml +++ b/.github/workflows/generate-screenshots.yml @@ -39,6 +39,11 @@ jobs: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 runs-on: [ledger-live-4xlarge] steps: + - name: Docker Hub Login + uses: docker/login-action@v2 + with: + username: ${{ secrets.DOCKER_HUB_USERNAME }} + password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} - name: generate token id: generate-token uses: tibdex/github-app-token@v1 diff --git a/tools/actions/composites/update-snapshots-desktop/action.yml b/tools/actions/composites/update-snapshots-desktop/action.yml index 2cac6f7d1b66..0c864e4aa0d7 100644 --- a/tools/actions/composites/update-snapshots-desktop/action.yml +++ b/tools/actions/composites/update-snapshots-desktop/action.yml @@ -11,12 +11,6 @@ inputs: runs: using: "composite" steps: - - name: Docker Hub Login - uses: docker/login-action@v2 - with: - username: ${{ secrets.DOCKER_HUB_USERNAME }} - password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} - - name: Update playwright snapshots [Linux => xvfb-run] if: ${{ startsWith(inputs.os, 'ubuntu') }} run: |