Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExchangeModule: fixed incorrect fee strategy types #8938

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

ExchangeModule: fixed incorrect fee strategy types #8938

wants to merge 1 commit into from
+6 −1

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Jan 17, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

This PR is required to trigger new exchange module version for LedgerHQ/exchange-sdk#95

fee Strat is case sensitive on LL and requires all lower case.
This fix will prevent redefinition of the type in swap live app

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner January 17, 2025 09:55
@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:02am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:02am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:02am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:02am

@CremaFR CremaFR changed the title fixed incorrect fee strategy types ExchangeModule: fixed incorrect fee strategy types Jan 17, 2025
sarneijim
sarneijim approved these changes Jan 20, 2025 •
edited
Loading
View reviewed changes
@sarneijim sarneijim self-requested a review January 20, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarneijim sarneijim Awaiting requested review from sarneijim

Assignees

@CremaFR CremaFR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CremaFR @sarneijim