Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.MD should mention flake section within installation section #802

Closed
vegabook opened this issue Nov 8, 2023 · 4 comments
Closed

README.MD should mention flake section within installation section #802

vegabook opened this issue Nov 8, 2023 · 4 comments

Comments

@vegabook
Copy link
Contributor

vegabook commented Nov 8, 2023 •
edited
Loading

https://github.com/LnL7/nix-darwin/blob/master/README.md?plain=1#L14-L21

These lines warn that the "Using darwin-installer is no longer necessary on flake based systems", but does not provide an explanation on how to install if are using a flake based system.

Flakes are mentioned lower but might be worth adding this right here (as in "see below") so that it is part of the "installation" section.
@vegabook vegabook changed the title README.MD does not specify how to install if we are using a flake-based setup README.MD should mention flake section upfront Nov 8, 2023
@vegabook vegabook changed the title README.MD should mention flake section upfront README.MD should mention flake section within installation section Nov 8, 2023
@Enzime
Copy link
Collaborator

Enzime commented Nov 9, 2023

Would you be able to make a PR? It would be great if you could add a link to the flake installation instructions so users could click to go straight there

@vegabook
Copy link
Contributor Author

Would you be able to make a PR? It would be great if you could add a link to the flake installation instructions so users could click to go straight there

#810

@MunsMan
Copy link

MunsMan commented Jun 13, 2024

Should the issue be closed, after the pull request was successfully merged?

@emilazy
Copy link
Collaborator

emilazy commented Jun 13, 2024

yep

@emilazy emilazy closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vegabook @Enzime @emilazy @MunsMan