From 67d99408b6b0a353f47c6f5b4a419247c7685f0b Mon Sep 17 00:00:00 2001 From: Sam Bray Date: Thu, 14 Nov 2024 09:36:30 -0800 Subject: [PATCH 1/3] no transactions v0 spikesorting --- src/spyglass/spikesorting/v0/spikesorting_curation.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/spyglass/spikesorting/v0/spikesorting_curation.py b/src/spyglass/spikesorting/v0/spikesorting_curation.py index 27aa074d3..77a4e8edb 100644 --- a/src/spyglass/spikesorting/v0/spikesorting_curation.py +++ b/src/spyglass/spikesorting/v0/spikesorting_curation.py @@ -324,6 +324,8 @@ class WaveformSelection(SpyglassMixin, dj.Manual): @schema class Waveforms(SpyglassMixin, dj.Computed): + use_transaction, _allow_insert = False, True + definition = """ -> WaveformSelection --- @@ -523,6 +525,8 @@ def insert1(self, key, **kwargs): @schema class QualityMetrics(SpyglassMixin, dj.Computed): + use_transaction, _allow_insert = False, True + definition = """ -> MetricSelection --- From 9e596121de91dde9bb859a067311d48745836521 Mon Sep 17 00:00:00 2001 From: Sam Bray Date: Thu, 14 Nov 2024 09:43:03 -0800 Subject: [PATCH 2/3] update changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dd3bbeeb3..86058203b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,7 +17,7 @@ dj.FreeTable(dj.conn(), "common_session.session_group").drop() ### Infrastructure - Disable populate transaction protection for long-populating tables #1066, - #1108, #1172 + #1108, #1172, #1187 - Add docstrings to all public methods #1076 - Update DataJoint to 0.14.2 #1081 - Allow restriction based on parent keys in `Merge.fetch_nwb()` #1086, #1126 From b55481c72debda94ef86a497ab227a55303bcc02 Mon Sep 17 00:00:00 2001 From: Sam Bray Date: Thu, 14 Nov 2024 10:56:35 -0800 Subject: [PATCH 3/3] no transact on v0 recording --- src/spyglass/spikesorting/v0/spikesorting_recording.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/spyglass/spikesorting/v0/spikesorting_recording.py b/src/spyglass/spikesorting/v0/spikesorting_recording.py index a6a356a33..16fbf3544 100644 --- a/src/spyglass/spikesorting/v0/spikesorting_recording.py +++ b/src/spyglass/spikesorting/v0/spikesorting_recording.py @@ -291,6 +291,8 @@ class SpikeSortingRecordingSelection(SpyglassMixin, dj.Manual): @schema class SpikeSortingRecording(SpyglassMixin, dj.Computed): + use_transaction, _allow_insert = False, True + definition = """ -> SpikeSortingRecordingSelection ---