Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default log level leaks ip querry domain now #15

Open
1 task
LuckyTurtleDev opened this issue Sep 2, 2023 · 2 comments · Fixed by #23
Open
1 task

default log level leaks ip querry domain now #15

LuckyTurtleDev opened this issue Sep 2, 2023 · 2 comments · Fixed by #23
Labels
privacy

Comments

@LuckyTurtleDev
Copy link
Owner

LuckyTurtleDev commented Sep 2, 2023 •
edited
Loading

Todo:
@LuckyTurtleDev
Copy link
Owner Author

hickory-dns/hickory-dns#2014 does not make much progress. So I think it would be the best to impl our own filtering for now.
The best think should be to match the private data with a regex and replace them, with a placeholder.

@LuckyTurtleDev LuckyTurtleDev mentioned this issue Oct 29, 2023
Merged
@LuckyTurtleDev
Copy link
Owner Author

#23 has fix large parts of this issue. But toplevel domains like fritzbox. will still be looked since matching by a regex would cause to main false positives. Lucky query toplevel domains is not very common. However this no guarantee that all private in all edge-cases is not logged. A upstream solution at trust/hickory-dns is still desirable.

LuckyTurtleDev added a commit that referenced this issue Oct 29, 2023
@LuckyTurtleDev
filter domain and ip from log; fix #15 partly. (#23)
a5a1ed7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
privacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

filter domain and ip from log LuckyTurtleDev/crab-hole
1 participant
@LuckyTurtleDev