Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed okwarning block warning #389

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mhmohona
Copy link
Contributor

@mhmohona mhmohona commented Oct 13, 2024

Fixed okwarning block warning
Ignored DCDReader currently makes independent timesteps warning.

Close - #378


📚 Documentation preview 📚: https://mdanalysisuserguide--389.org.readthedocs.build/en/389/

@RMeli
Copy link
Member

RMeli commented Oct 14, 2024

@mhmohona if you write "Close #378" instead of "Closes - #378" the issue will automatically close when the PR is merged, which is useful.

doc/source/conf.py Outdated Show resolved Hide resolved
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue — really much appreciated.

Could you please try to solve the issue with only using sphinx directives? Hopefully, no Python code is needed.

doc/source/conf.py Outdated Show resolved Hide resolved
doc/source/conf.py Outdated Show resolved Hide resolved
@orbeckst orbeckst self-assigned this Dec 18, 2024
@orbeckst
Copy link
Member

Can you please merge the current develop branch into this one here? This should make the mda_gh_ci_tests / examples-tests (pull_request) pass.

Did you check if :suppress: works?

@orbeckst
Copy link
Member

Can you please also edit your original PR comment following #389 (comment) so that it will automatically close the related issue? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify :okwarning: as an option in the ipython:: block to suppress a warning
3 participants