Pld Optimized Rotation Change

[MarvinAkil]

At the moment the mod uses atonement -> fast blade -> riot blade -> supplication -> sepulchre -> Holy Spirit.

Optimal filler rotation is atonement -> fast blade -> riot blade -> supplication -> Holy Spirit -> sepulchre

Could this be changed into that rotation. Cause atm its not useful to use it at all as it is not optimal at all

[MKhayle]

@kaedys hi, have fun

[kaedys]

You put it incredibly confusingly, tbh, but suffice it to say, the order specifically of Holy Spirit and Supplication doesn't matter. They have identical potency. Technically there's a tiny chance that you'd have to disengage during that GCD of FoF and thus Holy Spirit could be used where Supplication could not, but if you're worried about optimization on that scale, you shouldn't be using a mod like this in the first place (or at the least, not using the Atonement Royal Authority feature).

I can swap the priority of Holy Spirit and Supplication/Sepulchre, though. That's pretty easy. Worth noting that this is a pretty niche case (though to be fair, the option in question does specify it is an advanced optimization option, so that tracks). The only time this can make a difference is if FoF comes off cooldown (or gets used) precisely during the 2nd GCD before Royal Authority, so whatever is left unused before that Royal Authority is the first of the 3 spare GCDs in FoF. In that case, it's a gain of 40p to be able to use Sepulchre -> Royal Authority -> Holy Spirit over the current Holy Spirit -> Royal Authority -> Holy Spirit that would be used.

[MarvinAkil]

Im just writing this, as the combo i have written above is the one which is specified by balance. It does matter as it will make Sure to delay sepulchre as much as you can. Atm sepulchre is used 1 gcd earlier than it should be.

Its not a necessary change if you dont want to. Its definitly the filler which guarantees as much sepulchre in your fof as you want

[kaedys]

I'm swapping the priority of Holy Spirit and finishing the Atonement combo. That will place Sepulchre in the correct spot, used immediately prior to Royal Authority. That part wasn't an issue.

I was planning on just swapping the priority of Holy Spirit and finishing the Atonement combo, which would put Sepulchre in the correct spot but swap Supplication and Holy Spirit (so the "normal" combo outside FoF would have been Holy Spirit -> Supplication -> Sepulchre instead of Supplication -> Holy Spirit -> Sepulchre). However, the code to handle the actual recommended order isn't as bad as I thought, and looking at it, it's actually two GCDs in FoF it provides disconnect protection against, rather than just one GCD, and provides some minor disconnect protection for a further GCD during the normal combo, so I'm going to do that part as well.

[MarvinAkil]

Perfect!

[kaedys]

Ok, well, I now have forty lines of comments in the Paladin file, in 3 locations within the main combo block, just annotating all the wacky shit we're doing to optimize Atonement and Holy Spirit in and out of FoF. O.O

[MarvinAkil]

[kaedys]

I'm definitely in camp "it's better to have too much documentation than not enough" >.>

[MKhayle]

Ok, well, I now have forty lines of comments in the Paladin file, in 3 locations within the main combo block, just annotating all the wacky shit we're doing to optimize Atonement and Holy Spirit in and out of FoF. O.O

and despite those comments I was unable to figure out whether the Holy Spirit/Holy Combo issue was a secret nerd balance optimization or a c/p error 😆

[kaedys]

Haha, that's partially because I didn't really annotate the Prominence combo at all, because it doesn't really have any optimization. The only change that happens over there is that Holy Circle is only used when it would be overwritten, except during FoF where it is used immediately.

[MarvinAkil]

I'm definitely in camp "it's better to have too much documentation than not enough" >.>

definetly better to be in that camp

[kaedys]

Since it didn't auto-link here, #419