Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'params' apparently ignored with 'copy' #100

Open
xsurfing opened this issue Feb 2, 2016 · 1 comment
Open

'params' apparently ignored with 'copy' #100

xsurfing opened this issue Feb 2, 2016 · 1 comment

Comments

@xsurfing
Copy link

xsurfing commented Feb 2, 2016

Scenario: Upload and copy files w/ specific file permission. Example:
{code}
aws_s3: {
options: {
bucket: 'foo',
access: null,
accessKeyId : process.env.AWS_ACCESS_KEY_ID,
secretAccessKey: process.env.AWS_SECRET_ACCESS_KEY,
region: process.env.AWS_DEFAULT_REGION,
uploadConcurrency:30,
downloadConcurrency:10,
copyConcurrency:60,
differential:true,
progress: 'dots',
params : {
'GrantFullControl':'id=WhateverIDYouHave'
}
},
dev: {
files: [
{
'action': 'upload', expand:true, cwd:'webroot/dist', src: ['*/.txt'], dest: 'viewer_<%= svninfo.rev %>/'
},
{'action':'copy', src:'viewer_<%= svninfo.rev %>/', dest:'viewer_latest/'}
]
},
{code}

This results in files/folders "viewer_xxx" to have correct permissions, the copied version "viewer_latest" only having defaults.

@MathieuLoutre
Copy link
Owner

Hi there! You seem to be right, currently params is ignored during the copy: https://github.com/MathieuLoutre/grunt-aws-s3/blob/master/tasks/aws_s3.js#L471
This should be a fairly simple PR if you'd like to try your hand at it, otherwise I'll have to look into it when I get the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants