Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should population_term and observation_term be mandatory in meta_forestly? #43

Closed
yuliasidi opened this issue May 3, 2024 · 1 comment

Comments

@yuliasidi
Copy link
Collaborator

Since each forest plot is specified for a particular population/subset of observations - do the population_term and observation_term really need to be defined? The actual subsetting is already specified in population_subset and observation_subset, therefore, requiring a user to give these subsets names for generating one plot seems to be redundant.

Please consider either removing these arguments or assigning some default values so users don't need to deal with the additional unnecessary parameters specification.

@elong0527
Copy link
Collaborator

Closed per #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants