Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rate_compare: delta = 0 or delta = delta? #208

Open
jialuo-liu opened this issue Nov 18, 2024 · 1 comment
Open

rate_compare: delta = 0 or delta = delta? #208

jialuo-liu opened this issue Nov 18, 2024 · 1 comment

Comments

@jialuo-liu
Copy link

https://github.com/Merck/metalite.ae/blob/aab6a5e544942042988fa6ab20661daa3f3d3d1b/R/rate_compare.R#L119C5-L119C15

delta = delta?
@nanxstats
Copy link
Collaborator

@elong0527 is this an intended feature or a bug?

I do agree that it is confusing to have a delta argument in rate_compare() while never actually used in the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nanxstats @jialuo-liu