Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Elaborate Serializing and Deserializing of Data #162

Open
andrewpeters9 opened this issue Feb 12, 2023 · 0 comments
Open

Elaborate Serializing and Deserializing of Data #162

andrewpeters9 opened this issue Feb 12, 2023 · 0 comments

Comments

@andrewpeters9
Copy link

andrewpeters9 commented Feb 12, 2023

There seems to be some inconsistencies with how data is serialized and deserialized in some of the Metamask keyring libraries.

For the Trezor keyring:

  • this.paths is included in serialization, but not in deserialization
  • this.hdk can/should be serialised and deserialised
    • Only the publicKey and chainCode need to be serialised/deserialised
  • this.hdPath can be changed via deserialization without triggering the this.setHdPath method
  • Some "resetting" of data can be refactored (i.e., see forgetDevice, setHdPath and the constructor)
  • Setting this.hdKey can be refactored via a setHdKey method
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant