Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates token handling for Azure #234

Merged

Conversation

SokolovAnatoliy
Copy link
Contributor

Description of changes

This pull request addresses token management for Azure Open AI tokens. The token is saved to a gptstudio specific directory and ensures that tokens are properly refreshed as needed.

@calderonsamuel
Copy link
Collaborator

calderonsamuel commented Oct 31, 2024

Thank you for taking the time to contribute!

Some comments:

  1. This PR doesn't seem to be linked to an issue, so I have no context on what problem it solves
  2. New dependency Microsoft365R should be stated in DESCRIPTION. Using require() in the .onLoad() function seems a bit strange to me. We don't do that for any other package, so I would like to know the reasons.
  3. Do you know any programatically way to test that this does what is expected?
  4. I'm curious on why you didn't use the full PR template

@JamesHWade
Copy link
Collaborator

Tony and I talked about the PR a few days ago (we work together). This does better handling of the Azure token. Before we were generating a token way too often.

Copy link
Collaborator

@JamesHWade JamesHWade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let me know if you have any questions.

R/service-azure_openai.R Outdated Show resolved Hide resolved
R/zzz.R Outdated Show resolved Hide resolved
R/cache.R Outdated Show resolved Hide resolved
R/service-azure_openai.R Outdated Show resolved Hide resolved
R/service-azure_openai.R Outdated Show resolved Hide resolved
@calderonsamuel
Copy link
Collaborator

Tony and I talked about the PR a few days ago (we work together). This does better handling of the Azure token. Before we were generating a token way too often.

Thanks @JamesHWade , I'll move away from this one then

@SokolovAnatoliy
Copy link
Contributor Author

Thanks for all your suggestions and comments. I pushed a commit to resolve all of your suggestions.

@JamesHWade
Copy link
Collaborator

Thank you for the contribution!

@JamesHWade JamesHWade merged commit 1b28eb7 into MichelNivard:main Dec 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants