Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New checks/update getter for molar_mass in constituents object #620

Open
peverwhee opened this issue Dec 24, 2024 · 0 comments
Open

New checks/update getter for molar_mass in constituents object #620

peverwhee opened this issue Dec 24, 2024 · 0 comments
Assignees

Comments

@peverwhee
Copy link
Collaborator

Description

It would be nice to have:

  1. A check of whether molar_mass is set to 0 (which would return an error message) since molar_mass is often used as a denominator in unit conversions
  2. Return an errmsg from the getter if the molar_mass = kphys_unassigned (probably no error code, but just would be nice to have a clean way for the host to know if molar mass has been assigned)

Solution

  1. Add check to instantiate() that returns an errmsg (and probably and errcode) if molar mass is being set to 0
  2. Modify ccp_molar_mass to return a message when

Alternatives (optional)

If applicable, add a description of any alternative solutions or features you've considered.

Related to (optional)

Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant