Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing extra coordinates is awkward #11

Open
timothyas opened this issue Dec 21, 2023 · 0 comments
Open

Storing extra coordinates is awkward #11

timothyas opened this issue Dec 21, 2023 · 0 comments

Comments

@timothyas
Copy link
Member

Right now if there are extra coordinates in the dataset that are not variable dimension (for example, grid rotation angle fields), then these are stored in a separate dataset. This is a holdover from how I implemented this code in UFS-RNR, where we were writing a separate zarr store at every forecast initialization, but it's not really necessary for this workflow where we're putting the whole zarr store in one place. It makes more sense to just have the coordinates there.

Additionally this will get rid of the annoying "coords_kwargs" option to UFSDataset.store_dataset. If we're saying e.g. mode="w" to overwrite a dataset, we probably don't want to separately do this for the coordinates as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant