Skip to content
This repository has been archived by the owner on Apr 7, 2023. It is now read-only.

Eliminate usage of gen-region.sh #46

Open
marvinmarnold opened this issue Oct 25, 2021 · 4 comments
Open

Eliminate usage of gen-region.sh #46

marvinmarnold opened this issue Oct 25, 2021 · 4 comments

Comments

@marvinmarnold
Copy link

Services can now retrieve the region from the miner directly via hm_pyhelper.miner_json_rpc.get_region. There is no longer a need for gen-region.sh to write the region to file.

Acceptance criteria

  • hm-miner: Remove gen-region.sh and all references to it.
  • hm-pyhelper: Update logic in hm_pyhelper.miner_param.retry_get_region to invoke hm_pyhelper.miner_json_rpc.get_region instead of reading from file.
  • hm-pktfwd: Remove references to REGION_FILEPATH in hm-pktfwd.
  • Double check there are no other services that depend on the region file. At the time of writing, only hm-pktfwd uses this method.
@shawaj
Copy link
Member

shawaj commented Oct 26, 2021

IIRC config at some point used it for outputting diagnostics info.

Other than that I think just UPnP

https://github.com/NebraLtd/hm-upnp/blob/56722295754eddc65496c3f08f0cb35e76ad0586/configureUpnp.py#L6-L22

@shawaj
Copy link
Member

shawaj commented Oct 26, 2021

TBH the UPnP container is probably best to be deprecated in favour of hm-watchdog when we implement that IMO

Or we could stick the UPnP stuff in hm-config as that already has host networking set up in docker compose

@shawaj
Copy link
Member

shawaj commented Oct 26, 2021

@shawaj
Copy link
Member

shawaj commented Nov 4, 2021

Only problem with this, is that JSON RPC is unreliable...

NebraLtd/hm-diag#195

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants