Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more convencience methods for arithmetics with Vector{QQFieldElem} #1559

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

YueRen
Copy link
Contributor

@YueRen YueRen commented Oct 19, 2023

Proposed changes for #1555

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1559 (9c3c893) into master (4f99e9e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1559      +/-   ##
==========================================
- Coverage   84.19%   84.18%   -0.01%     
==========================================
  Files          94       94              
  Lines       36602    36607       +5     
==========================================
+ Hits        30818    30819       +1     
- Misses       5784     5788       +4     
Files Coverage Δ
src/flint/fmpq.jl 85.20% <100.00%> (+0.16%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YueRen
Copy link
Contributor Author

YueRen commented Oct 19, 2023

I don't understand why I am failing the codecov test. If it is critical for merging the pull request, then help would be appreciated.

@thofma
Copy link
Member

thofma commented Oct 19, 2023

No, it is not critical. Ignore it. The important bit is the coverage for the patch, which is at 100%!

@YueRen
Copy link
Contributor Author

YueRen commented Oct 19, 2023 via email

@thofma thofma merged commit f2e3115 into Nemocas:master Oct 19, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants