RPC update - add l2 gas #2335
Open
RPC update - add l2 gas #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2335 +/- ##
==========================================
+ Coverage 74.62% 74.93% +0.30%
==========================================
Files 110 110
Lines 12024 12072 +48
==========================================
+ Hits 8973 9046 +73
+ Misses 2354 2332 -22
+ Partials 697 694 -3 ☔ View full report in Codecov by Sentry. |
kirugan
reviewed
Dec 18, 2024
AnkushinDaniil
force-pushed
the
daniil/update-rpc
branch
from
0b11ce6 to
49278bf
Compare
weiihann
reviewed
Dec 23, 2024
weiihann
reviewed
Dec 23, 2024
weiihann
reviewed
Dec 23, 2024
AnkushinDaniil
force-pushed
the
daniil/update-rpc
branch
from
bfeb90f to
5bf7f2b
Compare
kirugan
reviewed
Dec 24, 2024
kirugan
reviewed
Dec 24, 2024
| return nil, httpHeader, err | ||
| } | ||
|
|
||
| return utils.Map(result, func(tx SimulatedTransaction) FeeEstimateV0_7 { |
There was a problem hiding this comment.
you can pass function name (=pointer) like:
return utils.Map(result, FeeEstimateToV0_7)
There was a problem hiding this comment.
I don't think so, feeEstimateToV0_7 adapts FeeEstimate, not SimulatedTransaction.
return utils.Map(result, feeEstimateToV0_7) requires changes in feeEstimateToV0_7.
kirugan
reviewed
Dec 24, 2024
AnkushinDaniil
force-pushed
the
daniil/update-rpc
branch
2 times, most recently
from
dfa0789 to
eed5b3e
Compare
AnkushinDaniil
force-pushed
the
daniil/update-rpc
branch
from
a476172 to
fccabd3
Compare
AnkushinDaniil
force-pushed
the
daniil/update-rpc
branch
4 times, most recently
from
968275a to
c1abd7a
Compare
adapters/core2p2p/block.go
Outdated
Comment on lines
60
to
61
| L2GasPriceFri: AdaptUint128(header.L2GasPriceSTRK.NilToZero()), | ||
| L2GasPriceWei: AdaptUint128(header.L2GasPriceETH.NilToZero()), |
There was a problem hiding this comment.
If this values cannot be nil they should be handled explicitly up top.
There was a problem hiding this comment.
AnkushinDaniil
force-pushed
the
daniil/update-rpc
branch
from
c1abd7a to
1326b54
Compare
AnkushinDaniil
force-pushed
the
daniil/update-rpc
branch
from
1326b54 to
6dcb2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2323
Fix #2324
Fix #2334
Implement RPC changes regarding
l2_gasCore Data Structures and Adaptation Functions:
core/block.go: Updated theHeaderstruct to includeL1GasPriceETH,L2GasPriceETH,L1GasPriceSTRK, andL2GasPriceSTRKfields, replacing the previousGasPriceandGasPriceSTRKfields. [1] [2]adapters/p2p2core/block.go: Updated theAdaptBlockHeaderfunction to include the new L1 and L2 gas price fields.adapters/sn2core/sn2core.go: Adjusted theAdaptBlockfunction to handle the new gas price fields.RPC:
rpc/block.go: Updated theBlockHeaderstruct andadaptBlockHeaderfunction to include L2 gas prices. [1] [2]rpc/estimate_fee.go: Introduced a newFeeEstimatestruct to handle L1 and L2 gas prices and added a versionedEstimateFeeV0_7function for backward compatibility. [1] [2] [3]Test Cases:
adapters/sn2core/sn2core_test.go: Updated test cases to assert the new gas price fields.rpc/block_test.go: Added assertions for L2 gas prices in the relevant test cases. [1] [2] [3]rpc/estimate_fee_test.go: Included tests for the newEstimateFeeV0_7function.rpc/events_test.go: Updated expected JSON responses to include L2 gas prices. [1] [2]