-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Awkward Alert behavior when phone is in Do Not Disturb mode #2101
Comments
I have been using xDrip for several years. I don't have the notification channels enabled. I just did the test you described. I got the notification and swiped it away to quiet the alert. I have experienced the same thing on multiple phones over the years from Android 5 up to Android 11 now. |
Would you please in Android go to the following page and see what you have? Settings −> Apps & notifications −> Notifications −> xDrip+ |
In my opinion, the highest priority issue with the alerts right now is the following: Missed reading alert, Forecast low and persistent high alert can be missed when asleep because those particular alerts cannot use the ascending volume profile. In other words, their volume is not dictated by xDrip. It is controlled by the phone volume, which the user may have lowered for any reason and forgotten about it. Imagine if you wake up in the morning and find out that you have had no readings (connectivity) for the past 8 hours. |
I believe that overriding dnd defaults to off on phone versions that support it and on Android 12 (Tested google pixel) there is no option available to do that at all and the problem exists there also as I have seen on Android 11 - Additionally we want the user to be able to control this which is why there is the "override silent mode" feature on a per alarm basis. This gives the user flexibility to do things like have alerts not embarrass them when they want to be on dnd during the day but to override that at night regardless. I'm also thinking about adding a button to the notification Regarding problems with other alerts being missed with low system volume, please raise another issue for it. |
I tested this on an Android 9 device and the issue doesn't seem present there. |
I have this: #1762 |
Just to be clear, the setting I have shown in the attached image only has to do with notifications, so that the notification is shown on screen so that the user can swipe it to snooze it. It has nothing to do with the sound of the alert.
How can it be easier than swiping right? |
The ascending volume profile is the best solution for not being embarrassed in public. The alert starts at extremely low (30%) volume. So, no one else can hear it. One can even delay the sound by 3 minutes, during which there will only be vibrations. Of course, again, not all alerts can use the ascending volume profile currently. Again, if we make all alerts consistent, we will allow all alerts to use it. I hope the following does not offend anyone. Because that's not my intent: |
I've added support here: a7bdf97 The alert buttons are controlled by an option. For now I have defaulted this to off to mimic existing behavior. If we think this is good then in future it can be changed to default to on. It depends perhaps on whether users might find it too easy to cancel an alert and whether that could happen accidentally. The button does make it more obvious how to silence the alert though. I've tested this on Android 8,9,10,11 and 12 but there might still be issues with various manufacturers who interpret how notifications are handled differently so we should be mindful of this change. I will focus on the single shot alert volumes next, eg low prediction and friends. |
I'm testing it with the new option enabled. |
I can see the button is quite large. I wonder how easy it is for someone to swipe it back up to just collapse the notification without snoozing. I will test it the next time I get an alert. |
I got an alert when the screen was locked. After I unlocked the phone, it was on the alert snooze page. This is a new behavior. Is this change intentional? I prefer to be on the main screen when I unlock the phone even if there is an alert. |
And I cannot hear any alarm when this happens. This is bad. I have disabled the setting. Something is really wrong. |
Do you mean the snooze button setting? |
Ok yes, but I was referring to you saying that you didn't get any sound. |
It happened once when I was getting an alert on BlueJay but not from the phone. When I unlocked, I was on the snooze page and I couldn't hear an alert. At that time, I had the new setting enabled. Regardless, I don't think the phone should unlock on the snooze page. |
It's like we are encouraging the user to snooze the alert. |
The type of notification that it is using to bypass DND maybe can trigger the content action to be triggered on unlock, the same destination as if you tap an alert notification from the notification area. Its not really an intended change of behavior just a side effect of how these notifications work. I can alter the destination for that but I'm not sure why it would be so much of a problem. The user should be snoozing an alert as soon as they are aware of it. There is very little point their phone continuing to make noise once they are aware of the alert. Please explain to me why you think otherwise. |
I've been unable to reproduce any problem with the sound not playing so please let me know if you get that again as I would rate it as a serious problem. |
Imagine a parent goes to their child's room to see why their phone is generating an alert. Scenario 2: |
Okay. I can make it go to the home screen but on mine it shows the glucose value on the lock screen as part of the notification before unlock. |
Thanks. Please change it back. I don't see my blood glucose on the lock screen. I'm sure I can figure out how to do it if I want to. But, I don't think it is like that for everyone by default. Hence, my request to change it back to unlock to the main screen. |
The issue of not hearing the alert happened again. |
Isn't that how ascending profile would normally work? |
May 8th nightly has the change for the lock screen notification to open to the home screen of xDrip instead of the snooze page. I also made another change which should revert any possible change to when vibrations occurred when Samsung phones were on DND and the alert wasn't set to override DND. I'm thinking to keep the SNOOZE ALERT button inside the notifications disabled by default as its probably too easy to cancel alerts. For example on mine its possible to press the button even when the phone is locked. I'm not sure what that would do if it were in a pocket. But I will leave the option there for anyone who wants to enable it. |
One who uses the ascending volume profile, has two options as explained here: I choose not to delay the sound. So, my alerts start right away making sound. I will be testing the new release now. Thanks |
I think this issue is resolved now. I plan to close the issue soon. Please advise if seeing any problems with the latest. |
Unlocking the phone unlocks on the main xDrip page now. Thanks a lot. I cannot be sure. But, I had to disable notifications making sound and vibrate again. I could be wrong. But, it's possible installing the latest release may have triggered that. |
The button is now hidden. One has to tap on the arrow in the notification to expose the button. So, we need to tell users about that. But, if we wanted to do that, why not just tell them that they can just swipe it? That's what I have been doing in my documentation. If it was possible to make the button smaller so that it wouldn't occupy the entire width of the notification so that the user could easily swipe the notification back up if wanted to, I would make the button visible all the time, and I would also remove the setting so that the button would always be visible for everyone. |
It seems that it has to do with how many notifications there are on the screen. Now that I have closed all the other notifications, pulling down from the top shows the button automatically. |
|
Summary:
When the phone is in do-not-disturb mode and an alert is raised, although the override silent mode allows the alert to sound, the actual notification is not visible.
This makes it very awkward to dismiss the alert as it requires opening xDrip and selecting the snooze item from the burger menu. This can be especially painful at 3am and also if the phone also requires key guard unlocking.
How to reproduce:
Go in to the Alerts list with your phone on DND mode, long press to edit an alert which has override silent mode enabled and click to test the alert. Make sure to have alert volume profile set to something like high before this.
What I expect you will see is the the alert noisily sounding but no visible notification to swipe off.
Tested on Android 11.
I'm working on a fix for this but will appreciate testing as behavior could be different on different android versions and also depending on whether the notification channel feature is enabled or not (is off by default)
The text was updated successfully, but these errors were encountered: