From c53f106335e484bed8496811ebe73a50def56bf2 Mon Sep 17 00:00:00 2001 From: Abhishek Dubey Date: Mon, 13 Jan 2025 12:19:51 +0530 Subject: [PATCH 1/3] Fixed CI steps for testing chart Signed-off-by: Abhishek Dubey --- .github/workflows/test-charts.yaml | 18 ++---------------- README.md | 8 -------- 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/.github/workflows/test-charts.yaml b/.github/workflows/test-charts.yaml index 26dc13aa..afd9dbbc 100644 --- a/.github/workflows/test-charts.yaml +++ b/.github/workflows/test-charts.yaml @@ -20,22 +20,8 @@ jobs: with: version: v3.5.4 - - name: Install yq - run: | - sudo snap install yq - - name: Install and test Redis Related Helm charts run: | kubectl cluster-info --context kind-kind - chart_dirs=("redis-operator" "redis" "redis-cluster" "redis-replication" "redis-sentinel") - for dir in "${chart_dirs[@]}" - do - if [[ -f ./charts/$dir/Chart.yaml ]]; then - helm dependency update ./charts/$dir/ - fi - chart_version=$(yq e .version ./charts/$dir/Chart.yaml) - echo "Installing $dir chart with version $chart_version..." - helm install $dir ./charts/$dir/ - helm test $dir - done - echo "Listing installed Helm charts..." + changed=$(ct list-changed --config ct.yaml) + ct install --config ct.yaml diff --git a/README.md b/README.md index a268b64e..94258825 100644 --- a/README.md +++ b/README.md @@ -14,14 +14,6 @@ helm repo add ot-helm https://ot-container-kit.github.io/helm-charts You can then run `helm search repo ot-helm` to see the charts. -### Helm Charts List - -Currently supported helm charts are:- - -- [Redis Operator](./charts/redis-operator) -- [Redis Standalone](./charts/redis) -- [Redis Cluster](./charts/redis-cluster) -- [K8s Vault Webhook](./charts/k8s-vault-webhook) ### Pre-Requisities From 5ee2e8112e5cbb3fa5ac308eee64ab0099b9ea1e Mon Sep 17 00:00:00 2001 From: Abhishek Dubey Date: Mon, 13 Jan 2025 12:22:53 +0530 Subject: [PATCH 2/3] Fixed CI steps for testing chart Signed-off-by: Abhishek Dubey --- .github/workflows/lint-test.yaml | 2 +- .github/workflows/test-charts.yaml | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index 9af87081..6457e2f7 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -15,7 +15,7 @@ jobs: - name: Install Helm uses: azure/setup-helm@v3 with: - version: v3.5.4 + version: v3.16.2 - uses: actions/setup-python@v4 with: diff --git a/.github/workflows/test-charts.yaml b/.github/workflows/test-charts.yaml index afd9dbbc..9f7d48cc 100644 --- a/.github/workflows/test-charts.yaml +++ b/.github/workflows/test-charts.yaml @@ -18,9 +18,12 @@ jobs: - name: Install Helm uses: azure/setup-helm@v3 with: - version: v3.5.4 + version: v3.16.2 - - name: Install and test Redis Related Helm charts + - name: Set up chart-testing + uses: helm/chart-testing-action@v2.6.0 + + - name: Install and test Helm charts run: | kubectl cluster-info --context kind-kind changed=$(ct list-changed --config ct.yaml) From 4188ce24643460f4a18a0df3a1535f06bea2e59f Mon Sep 17 00:00:00 2001 From: Abhishek Dubey Date: Mon, 13 Jan 2025 12:28:40 +0530 Subject: [PATCH 3/3] Fixed CI steps for testing chart Signed-off-by: Abhishek Dubey --- .github/workflows/lint-test.yaml | 2 +- .github/workflows/linter.yaml | 1 + .github/workflows/test-charts.yaml | 9 ++++++++- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index 6457e2f7..741b2031 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -8,7 +8,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 diff --git a/.github/workflows/linter.yaml b/.github/workflows/linter.yaml index f303b516..f15e4371 100644 --- a/.github/workflows/linter.yaml +++ b/.github/workflows/linter.yaml @@ -25,3 +25,4 @@ jobs: VALIDATE_YAML: false DEFAULT_BRANCH: main GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + FILTER_REGEX_EXCLUDE: .*(README\.md|NOTES.txt).* diff --git a/.github/workflows/test-charts.yaml b/.github/workflows/test-charts.yaml index 9f7d48cc..7af5a1a7 100644 --- a/.github/workflows/test-charts.yaml +++ b/.github/workflows/test-charts.yaml @@ -8,7 +8,9 @@ jobs: steps: - name: Check out code - uses: actions/checkout@v2 + uses: actions/checkout@v4 + with: + fetch-depth: 0 - name: Create k8s Kind Cluster uses: helm/kind-action@v1.5.0 @@ -23,6 +25,11 @@ jobs: - name: Set up chart-testing uses: helm/chart-testing-action@v2.6.0 + - uses: actions/setup-python@v4 + with: + python-version: '3.9' + check-latest: true + - name: Install and test Helm charts run: | kubectl cluster-info --context kind-kind