security risk: traceback_with_variables

[soxofaan]

@JeroenVerstraelen you originally added this traceback_with_variables feature here:

openeo-geopyspark-driver/openeogeotrellis/deploy/batch_job.py

Line 746 in 5e0f8cb

logger.info("Batch job error stack trace with locals", extra={"exc_info_with_locals": format_exc(e, fmt=fmt)})

But I've noticed that this exposes access keys in the (batch job) logs. It seems quite risky to blindly expose all local vars in our logs.

Do we still need or use this feature?

[soxofaan]

I already quickfixed this by disabling it for now in 7a507dd

maybe we should only enable this on dev deploys?

[JeroenVerstraelen]

It's good to disable it for now, I think a proper option to implement it could be to ensure that the user can never receive these particular logs. These extended tracebacks have been quite useful to me in the past when solving more difficult/transient issues.