[WIP] Enforce protocol settings at instantiation #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require Protocol authors to define the _settings_cls attribute for their class. __init__ method checks that _settings_cls is define (if not raise NotImplementedError) and that the passed settings are an instance of the _settings_cls (if not raise ValueError). Update existing Protocols in gufe to reflect this change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 39 39
Lines 2166 2170 +4
=======================================
+ Hits 2134 2138 +4
Misses 32 32 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require Protocol authors to define the _settings_cls attribute for their class. init method checks that _settings_cls is define (if not raise NotImplementedError) and that the passed settings are an instance of the _settings_cls (if not raise ValueError).
Update existing Protocols in gufe to reflect this change. Closes #405.
Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.
Checklist
newsentryDevelopers certificate of origin