New ring shader #867
Draft
New ring shader #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@TerrificTrifid is there a branch for NH Examples that demonstrates all the new features? |
|
Rings in this branch look pretty broken. Weird square artifact, and much much dimmer than they were before. Unlit rings are just invisible?
|
xen-42
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Notes:
- For backwards compat, just make rings look good. Test in Examples and any other mod that had rings.
- Rings do not cast shadows right now. They also don't have rings casted onto them. This is seen from checking in RSS. They should cast and receive shadows with default settings.
- Ring brightness changes depending on the player's distance to the rings. This should not happen.
- Rings in base solar system are really broken, see GD in examples.
- Rings vanish when seen from a distance. See Echo Hike. This shouldn't happen.
- Ideally rings wouldn't appear over top of atmospheres. Is that possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
transparencyType,useNoise(gives grainy appearance to rings),noiseScale,noiseRotationSpeed,translucency,translucentGlow,smoothnessMap,normalMap,emissionMap.