Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy vanilla dialogue translations if English contents is identical #853

Open
omega-fallon opened this issue Apr 29, 2024 · 2 comments
Open
Labels
nice to have Features that could be implemented maybe

Comments

@omega-fallon
Copy link

What Happened?

In a NH DialogueTree XML, if you copy paste dialogue from the vanilla game, it gets treated as totally new lines instead of being translated. According to Xen, this is a bug.

What was supposed to happen?

Lines were supposed to be translated since they are identical to existing lines in the vanilla game.

Platform

Steam

Mods

[
  "clubby789.OWClock",
  "OmegaFallon.SelfAtEye",
  "Owen_013.FirstPersonPresence",
  "Multiverse.Brightdusk",
  "dgarro.SuitLog",
  "VioVayo.HugMod",
  "O32.TimeDialator",
  "Walker.AstralCodex",
  "OmegaFallon.ReactiveHearthians",
  "_nebula.GlobalScreenSpaceReflections",
  "xen.SignalsPlus",
  "SBtT.CameraShake",
  "xen.CommonCameraUtility",
  "JohnCorby.VanillaFix",
  "xen.NewHorizons",
  "dgarro.CustomShipLogModes",
  "SBtT.GeneralEnhancements"
]

Logs

No response

@omega-fallon omega-fallon added the bug Something isn't working label Apr 29, 2024
@xen-42
Copy link
Member

xen-42 commented Apr 30, 2024

I changed my mind its not a bug! But yeah could still be fixed maybe

@xen-42 xen-42 added feature Features that should be implemented and removed bug Something isn't working labels Apr 30, 2024
@xen-42 xen-42 changed the title Copy-pasted vanilla dialogue does not get translated Copy vanilla dialogue translations if English contents is identical Oct 5, 2024
@xen-42
Copy link
Member

xen-42 commented Oct 7, 2024

To implement this we'd need to load the english translation XML manually (it isn't loaded if your game is in French), then reverse the dictionary so we can get keys from values, see if there is a value matching our string, grab its key, then look up that key in the loaded language xml.

@xen-42 xen-42 added nice to have Features that could be implemented maybe and removed feature Features that should be implemented labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have Features that could be implemented maybe
Projects
None yet
Development

No branches or pull requests

2 participants