Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps remove palindrom-redirect-pushstate #15

Open
warpech opened this issue Nov 21, 2018 · 2 comments
Open

Perhaps remove palindrom-redirect-pushstate #15

warpech opened this issue Nov 21, 2018 · 2 comments

Comments

@warpech
Copy link

warpech commented Nov 21, 2018

As explained in #14 (comment), the palindrom-redirect-pushstate event would be not needed if palindrom-redirect used a real anchor element in its Shadow DOM.

Implementation is already in place in branch: https://github.com/Palindrom/palindrom-redirect/tree/fix-attaching-alt

@tomalec, @alshakero WDYT?

Then we can remove palindrom-redirect-pushstate from PalindromDOM, which would be a breaking change that reduces the API surface.

@tomalec
Copy link
Member

tomalec commented Nov 21, 2018

Have I missed something, or you haven't pushed your changes master...Palindrom:fix-attaching-alt https://github.com/Palindrom/palindrom-redirect/network

warpech added a commit that referenced this issue Nov 21, 2018
rely on clicking on a link instead
@warpech
Copy link
Author

warpech commented Nov 21, 2018

Wow, thanks for noticing! I forgot to commit it :) Pls check the branch https://github.com/Palindrom/palindrom-redirect/tree/fix-attaching-alt again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants