Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod needs bumping #53

Closed
udf2457 opened this issue Sep 29, 2023 · 1 comment · Fixed by #78
Closed

go.mod needs bumping #53

udf2457 opened this issue Sep 29, 2023 · 1 comment · Fixed by #78

Comments

@udf2457
Copy link
Contributor

udf2457 commented Sep 29, 2023 •
edited
Loading

I noticed simpleblob go.mod is at 1.18.

Really this needs to be bumped.

Any reason not to ?

P.S. Also you might want to consider removing currently... from README.md otherwise you will be forever lagging behind. i.e. change We support the last two stable Go versions, currently 1.17 and 1.18. to We support the last two stable Go versions.
@udf2457
Copy link
Contributor Author

udf2457 commented Sep 29, 2023 •
edited
Loading

Hmm ... the NATS support I'm proposing in #59 (#55 ) is blocking because NATS is using strings.CutPrefix which only became available in 1.20.

go 1.22 is reasonably close to release so maybe its worth bumping up to 1.20 and skip 1.19 ?

@udf2457 udf2457 mentioned this issue Sep 29, 2023
Closed
@ahouene ahouene mentioned this issue Apr 9, 2024
Closed
@ahouene ahouene linked a pull request Oct 14, 2024 that will close this issue
Upgrade Go & dependencies, drop unsupported Go versions #78
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Go & dependencies, drop unsupported Go versions ahouene/simpleblob
1 participant
@udf2457