Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deprecated KG2 code, in light of Plover2.0 #2411

Open
22 of 29 tasks
amykglen opened this issue Nov 6, 2024 · 3 comments
Open
22 of 29 tasks

Clean up deprecated KG2 code, in light of Plover2.0 #2411

amykglen opened this issue Nov 6, 2024 · 3 comments
Assignees

Comments

@amykglen
Copy link
Member

amykglen commented Nov 6, 2024

created the branch kg2cleanup for this - plan is to do all work in this branch, and then only merge it to master after ITRB has already deleted their KG2 instances

code to cleanup:

  • make the cicd instance query the dev Plover2.0 KG2 instead of its own self-hosted KG2
  • update the KG2 rollout issue template
  • update the Dockerfile that cicd.rtx.ai uses - either make cicd.rtx.ai use the ARAX Dockerfile, or remove KG2 portions from MergedDockerfile? @sundareswarpullela will tackle this
  • remove the KG2 flask server directory: https://github.com/RTXteam/RTX/tree/master/code/UI/OpenAPI/python-flask-server/KG2 (note that we still need a yaml file for the KG2 smartapi registration, but that doesn't live in this directory - it's here)
  • get rid of mode == "rtxkg2" code in Expand
  • remove kg2_querier.py (verify pathfinder and other modules are no longer using)
    • remove usages of KG2Querier in ARAX_expander.py
    • looks like Pathfinder and CRG are using it - check with Mohsen/Kevin about this
    • @mohsenht will remove related code from pathfinder on Nov. 20
    • @kvnthomas98 will remove related code from CRG on Nov. 20
  • in KG2c build, don't create/upload the meta KG anymore (automatically provided by Plover)
  • update ARAX's node/edge decoration - should we still be doing this? Plover2.0 returns all attributes... do we still want to decorate other KPs' nodes/edges?
  • remove the 'force_local' mechanism from ARAX_expander (no longer relevant)
  • Update example here: https://github.com/RTXteam/RTX/blob/master/code/ARAX/Examples/kg2_api_example.py
  • Remove all the KG2 UI components and Apache configs and symlinks
  • Delete DockerBuild/kg2-config.js?
  • Delete KG2-Dockerfile?

other things to update:

deployment plan:

  • @edeutsch will turn off all arax.ncats.io/kg2* endpoints the week of Nov. 11 and verify
  • notify Translator community that KG2 URLs are changing (SmartAPI reg will be updated accordingly, but just a heads up for anyone with hard-coded URLs)
  • ask ITRB to remove all kg2.x.transltr.io instances on Friday Nov. 15 (after the ITRB PROD deployment is done on Thurs Nov. 14 and verified working)
  • after ITRB has removed their kg2 instances, we can merge kg2cleanup into master (pending testing)

please add anything else as you think of it!

@amykglen amykglen changed the title Cleaning up deprecated KG2 code, in light of Plover2.0 Clean up deprecated KG2 code, in light of Plover2.0 Nov 6, 2024
@edeutsch
Copy link
Collaborator

edeutsch commented Nov 7, 2024

Thank you @amykglen, this is really great and thorough!

@amykglen
Copy link
Member Author

amykglen commented Nov 15, 2024

so I updated the URLs on this wiki page: https://github.com/NCATSTranslator/Translator-All/wiki/KG2

which I think is what is used to populate this documentation page: https://ncatstranslator.github.io/TranslatorTechnicalDocumentation/architecture/kp/rtx-kg2/?h=rtx

but the latter hasn't shown the updates yet - not sure how that works or how often it's run... anyone know about that?

@amykglen
Copy link
Member Author

amykglen commented Dec 4, 2024

hey @sundareswarpullela - thanks for your work on the Dockerfiles for this issue. wondering - in the kg2cleanup branch, can we delete the KG2-Dockerfile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants