Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] <rh-blockquote>: centered demo not aligning properly #2103

Open
marionnegp opened this issue Jan 2, 2025 · 0 comments · Fixed by #2112
Open

[bug] <rh-blockquote>: centered demo not aligning properly #2103

marionnegp opened this issue Jan 2, 2025 · 0 comments · Fixed by #2112
Assignees
@adamjohnson
Labels
bug Something isn't working
Milestone
2025/Q1 — Cubone ...

Comments

@marionnegp
Copy link
Collaborator

Describe the bug

In this centered blockquote demo, it looks like the quote text isn't being centered correctly. Maybe the <blockquote> text might need to use text-align: center?

Screenshots

Screenshot 2025-01-02 at 1 59 20 PM

Steps to reproduce

  1. Visit the centered blockquote demo.
  2. View the quote in a wide window.

Expected behaviour

The quote text should be centered, like the icon and the citation.

Element HTML

No response

Operating System (OS)

macOS

Browser

No response

Additional browser or assistive technology info

No response
@marionnegp marionnegp added the bug Something isn't working label Jan 2, 2025
@adamjohnson adamjohnson self-assigned this Jan 8, 2025
@adamjohnson adamjohnson moved this from Backlog to In Progress 🟢 in Red Hat Design System Jan 8, 2025
@adamjohnson adamjohnson added this to the 2025/Q1 — Cubone release milestone Jan 8, 2025
@adamjohnson adamjohnson mentioned this issue Jan 8, 2025
Merged
@adamjohnson adamjohnson linked a pull request Jan 8, 2025 that will close this issue
fix(blockquote): fix center alignment, enforce blockquote font size and update Style docs #2112
Merged
@adamjohnson adamjohnson moved this from In Progress 🟢 to Done ☑️ in Red Hat Design System Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjohnson adamjohnson

Labels
bug Something isn't working
Projects
Red Hat Design System
Status: Done ☑️
Milestone
2025/Q1 — Cubone release
2 participants
@adamjohnson @marionnegp