You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When configurable product SKUs have double-quotes in them (although I realize double-quotes in SKUs are not ideal, that is what exists), then the richSnippet JS breaks. See screenshot below.
I think the most ideal solution would be to replace the double-quotes in the SKU data attribute in \Reviewscouk\Reviews\Block\Richsnippet::getRichSnippet with "template literals" (backticks). This is already done with the description.
If this is an acceptable solution, I can create a PR. Thanks.
Steps to reproduce the issue
Create a configurable product with a SKU that contains a double-quote.
Issue description
When configurable product SKUs have double-quotes in them (although I realize double-quotes in SKUs are not ideal, that is what exists), then the richSnippet JS breaks. See screenshot below.
I think the most ideal solution would be to replace the double-quotes in the SKU data attribute in
\Reviewscouk\Reviews\Block\Richsnippet::getRichSnippet
with "template literals" (backticks). This is already done with the description.If this is an acceptable solution, I can create a PR. Thanks.
Steps to reproduce the issue
What's the expected result?
What's the actual result?
Additional details / screenshot
The text was updated successfully, but these errors were encountered: