Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add PR check for <img> tags in the markdown #9402

Open
2 tasks
babakamyljanovssw opened this issue Oct 12, 2024 · 2 comments
Open
2 tasks

✨ Add PR check for <img> tags in the markdown #9402

babakamyljanovssw opened this issue Oct 12, 2024 · 2 comments
Assignees

Comments

@babakamyljanovssw
Copy link
Member

Cc: @bradystroud @adamcogan @bettybondoc @tiagov8

Hi Team,

Originated from #9376

Currently some markdown files contains HTML <img> tag to display images, and these should not be allowed. Instead we need to use Markdown ![]() syntax to display images.

Note: Some of these tags are in code blocks, so don't required to change them.

  • Add new PR check that checks edited markdown files for <img> tag, and it should ignore the ones inside code block

  • Make PR check required, PR can't be merged when it fails

Thanks

@tiagov8
Copy link
Member

tiagov8 commented Oct 15, 2024

Hi @babakamyljanovssw

Curious...

  1. Does this Issue include finding existing errors?
    OR
    it will work only for new PRs?

--

FYI - I've fixed all HTML syntax to be Markdown, leaving just the ones inside code blocks.
#9415

You may need to recreate a bad syntax to test out

@babakamyljanovssw
Copy link
Member Author

Hi @tiagov8

Does this Issue include finding existing errors?
OR
it will work only for new PRs?

This will work only for new PRs to avoid merging invalid content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants