-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No lockfiles rule #82
Comments
👍 Warning and not if it's in .gitignore. |
The rule should:
|
Good suggestions! |
Just adding that yarn can also be configured to not emit lockfiles on |
@silverwind Yup, but I don't use Yarn, so don't think it's worth introducing yet another meta file. |
Because those are just warnings, I guess they shouldn't/can't be auto-fixable?
Remove lock file
Create
Add |
I don't see why you couldn't auto-fix them. What you suggested above sounds fine. |
You're right, I was assuming that warnings shouldn't be auto-fixable. But actually they can. Thanks for the feedback! |
I never use lockfiles for my modules, only for applications to make sure that the application that is built has the exact same dependencies as the one I tested everything with. Maybe we should add this as a warning instead of an error? What if the lockfile is added to
.gitignore
, should we still warn?// @sindresorhus
The text was updated successfully, but these errors were encountered: